Introduction of Boxplots with outliers#237
Open
tobiasvandriessel wants to merge 5 commits intoplotters-rs:masterfrom
Open
Introduction of Boxplots with outliers#237tobiasvandriessel wants to merge 5 commits intoplotters-rs:masterfrom
tobiasvandriessel wants to merge 5 commits intoplotters-rs:masterfrom
Conversation
added 4 commits
March 11, 2021 14:41
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 68.83% 69.11% +0.27%
==========================================
Files 56 57 +1
Lines 4313 4439 +126
==========================================
+ Hits 2969 3068 +99
- Misses 1344 1371 +27
Continue to review full report at Codecov.
|
|
Hi, do you resolve the conflicts ? |
Author
|
@wangjiawen2013 I currently don't have the time to do so; I'll see if I can take a look in a few months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a Boxplot variant with outliers, but I don't know whether it's built the way you'd have liked, as I can imagine you would have liked to have it as a variant of a generic type. However, I decided to build something quick and dirty and figured you might as well think it's okay. I'm open to any suggestions, but I'm still a Rust beginner, so I'm not sure I can do exactly what you'd like.
Cheers.